Skip to content
This repository has been archived by the owner on Jul 23, 2019. It is now read-only.

Swift 3 support #36

Merged
merged 8 commits into from
Nov 14, 2016
Merged

Swift 3 support #36

merged 8 commits into from
Nov 14, 2016

Conversation

brockboland
Copy link
Contributor

Updated the Swift sample projects to use Swift 3. I think the template for the Cat2Cat output is fine how it is, but I'm curious to see if Travis has any issues running this.

@@ -1,10 +1,10 @@
language: objective-c
osx_image: xcode7
osx_image: xcode8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do they not have an 8.1 image yet? Or is this purposely 8 so that it uses 3.0 instead of 3.0.1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like they don't have an 8.1 image yet, but also: does it matter? I can't seem to find release notes or a changelog for 3.0.1.

Oh, I guess the Xcode release notes serve for 3.0.1 as well, but they don't say as much (grrr). Either way, I don't see any changes there that would impact how Cat2Cat works.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah i don't think it changed anything that wasn't already a little crazy, which I think we tried not to be here.

@brockboland
Copy link
Contributor Author

Looks like I need to switch this one to use scan for tests

@brockboland
Copy link
Contributor Author

There we go. @vokal/ios-developers @designatednerd review please?

@brockboland brockboland merged commit 7d1a4ab into vokal:master Nov 14, 2016
@brockboland brockboland deleted the swift3 branch November 14, 2016 15:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants