Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make vokomokum plugin work #1

Closed
5 tasks done
wvengen opened this issue Mar 12, 2019 · 1 comment
Closed
5 tasks done

Make vokomokum plugin work #1

wvengen opened this issue Mar 12, 2019 · 1 comment

Comments

@wvengen
Copy link
Member

wvengen commented Mar 12, 2019

To make the vokomokum plugin work again fully with the current Foodsoft version, the following is needed:

  • Currently login works with form parameters (req.set_form_data(data)) and charge-members works with a JSON body (req.content_type = 'application/json'; req.body = data.to_json). Adapt the members app or the Foodsoft vokomokum plugin to get both working.
  • When the members system gives an error when settling an order, handle this gracefully (instead of showing a fully empty screen right now).
  • Get wvengen/foodsoft@f29105a into Foodsoft, so that settling an order can be hooked properly (after testing), then remove commit from our foodsoft repo with used by us.
  • Test settling an order, and make sure transactions are made in the members system.
  • Test that sending payment reminders still does the right thing.
@wvengen
Copy link
Member Author

wvengen commented Aug 6, 2020

Note that the plugin moved to our foodsoft fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant