Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary source closing tag #40

Closed
pan-tom opened this issue Aug 29, 2019 · 1 comment
Closed

Unnecessary source closing tag #40

pan-tom opened this issue Aug 29, 2019 · 1 comment

Comments

@pan-tom
Copy link

pan-tom commented Aug 29, 2019

What is this feature about (expected vs actual behaviour)?

Without </source>

How can I reproduce it?

Try to minify:

$html = "\r\n
\t<source src="horse.ogg" type="audio/ogg">\r\n
\t<source src="horse.mp3" type="audio/mpeg">\r\n
\tYour browser does not support the audio element.\r\n
";

It produces additional </source> tags:

<audio controls><source src=horse.ogg type=audio/ogg><source src=horse.mp3 type=audio/mpeg> Your browser does not support the audio element. </source></source></audio>

voku added a commit that referenced this issue Aug 30, 2019
@voku
Copy link
Owner

voku commented Aug 30, 2019

Thanks for the bug report. It's fixed in version 4.0.1.

PS: same problem was fixed for "picture" & "video" tags

Happy coding!

@voku voku closed this as completed Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants