Resolve #99 - Optimize "_sanitize_naughty_javascript" #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…negative look behind - add test cases - change js test result (no longer false positive) Signed-off-by: Benjamin Fahl <git@fahl-design.de>
… false positive cases Signed-off-by: Benjamin Fahl <git@fahl-design.de>
Signed-off-by: Benjamin Fahl <git@fahl-design.de>
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
=========================================
Coverage 93.98% 93.98%
Complexity 183 183
=========================================
Files 2 2
Lines 665 665
=========================================
Hits 625 625
Misses 40 40
Continue to review full report at Codecov.
|
Signed-off-by: Benjamin Fahl <git@fahl-design.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #99
todo:
_sanitize_naughty_javascriptwith tests_do_never_allowed_afterwards(see test casestestXssCleanNeverAllowedAfterwards)This change is