Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated script MIME type not omitted on inline scripts #46

Closed
abuyoyo opened this issue Mar 16, 2020 · 1 comment
Closed

Deprecated script MIME type not omitted on inline scripts #46

abuyoyo opened this issue Mar 16, 2020 · 1 comment

Comments

@abuyoyo
Copy link
Contributor

abuyoyo commented Mar 16, 2020

Deprecated MIME type not omitted on inline scripts:

<script type="text/javascript">alert("Hello");</script>

minifies to:

<script type=text/javascript>alert("Hello");</script>

should minify to:

<script>alert("Hello");</script>

https://validator.w3.org/ flags this as

Warning: The type attribute is unnecessary for JavaScript resources.
abuyoyo added a commit to abuyoyo/HtmlMin that referenced this issue Mar 17, 2020
@abuyoyo
[+]: add test case
d40f241 
for issue voku#46
abuyoyo added a commit to abuyoyo/HtmlMin that referenced this issue Mar 17, 2020
@abuyoyo
[+]: fix for "doRemoveDeprecatedTypeFromScriptTag"
685158d 
- closes voku#46
- doRemoveDeprecatedTypeFromScriptTag now applies to script tags without src attribute
@abuyoyo abuyoyo mentioned this issue Mar 17, 2020
Closed
@voku
Copy link
Owner

voku commented Mar 22, 2020

Thanks for the bug report and for the fix. It's fixed in version 4.3.0

@voku voku closed this as completed Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@voku @abuyoyo