Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apis): add task minAvailable related fields #40

Merged
merged 2 commits into from
May 11, 2021

Conversation

shinytang6
Copy link
Member

Signed-off-by: shinytang6 1074461480@qq.com

Signed-off-by: shinytang6 <1074461480@qq.com>
Thor-wl
Thor-wl previously approved these changes May 7, 2021
@Thor-wl Thor-wl requested a review from william-wang May 7, 2021 01:33
@Thor-wl
Copy link
Contributor

Thor-wl commented May 7, 2021

/cc @william-wang

@Thor-wl Thor-wl enabled auto-merge (squash) May 7, 2021 01:33
@shinytang6
Copy link
Member Author

shinytang6 commented May 7, 2021

/cc @zen-xu

@Thor-wl Thor-wl requested a review from zen-xu May 7, 2021 03:25
zen-xu
zen-xu previously approved these changes May 7, 2021
auto-merge was automatically disabled May 7, 2021 16:25

Head branch was pushed to by a user without write access

@shinytang6 shinytang6 dismissed stale reviews from zen-xu and Thor-wl via f0911f1 May 7, 2021 16:25
@Thor-wl
Copy link
Contributor

Thor-wl commented May 8, 2021

Pleaes fix the DCO

Signed-off-by: shinytang6 <1074461480@qq.com>
@shinytang6
Copy link
Member Author

@Thor-wl @zen-xu This pr should be merged, then volcano-sh/volcano#1459 can move forward.

@Thor-wl Thor-wl requested a review from zen-xu May 10, 2021 02:43
@Thor-wl
Copy link
Contributor

Thor-wl commented May 10, 2021

/cc @zen-xu

@Thor-wl Thor-wl enabled auto-merge (squash) May 11, 2021 01:31
Copy link
Member

@kevin-wangzefeng kevin-wangzefeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@Thor-wl Thor-wl disabled auto-merge May 11, 2021 04:13
@Thor-wl Thor-wl enabled auto-merge (squash) May 11, 2021 04:14
@Thor-wl Thor-wl removed the request for review from william-wang May 11, 2021 04:14
@Thor-wl Thor-wl disabled auto-merge May 11, 2021 04:15
@Thor-wl Thor-wl merged commit 70cf288 into volcano-sh:master May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants