CRD numatopo scope change namespaced to cluster #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: huone1 <huwanxing@huawei.com>
|
/lgtm overall, it's lgtm. |
wpeng102
approved these changes
May 28, 2021
|
/approve |
Thor-wl
approved these changes
May 28, 2021
|
I'll merge this PR for the sign-off is already signed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: huone1 huwanxing@huawei.com
CRD numatopo define per node's cpu topology info, nothing with namespace, so it is better to be in cluster , not namespaced.
the generated clientset api can reduce the unnecessary arguments
the change is base on the review comment in another PR volcano-sh/resource-exporter#1