Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete vendor && optimize the way to generate apis #48

Merged
merged 2 commits into from
Jun 2, 2021

Conversation

huone1
Copy link
Contributor

@huone1 huone1 commented Jun 1, 2021

Signed-off-by: huone1 huwanxing@huawei.com

wpeng102
wpeng102 previously approved these changes Jun 1, 2021
Copy link
Member

@wpeng102 wpeng102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thor-wl
Thor-wl previously approved these changes Jun 1, 2021
hack/generate-internal-groups.sh Outdated Show resolved Hide resolved
hack/generate-groups.sh Outdated Show resolved Hide resolved
william-wang
william-wang previously approved these changes Jun 1, 2021
Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Signed-off-by: huone1 <huwanxing@huawei.com>
@huone1 huone1 dismissed stale reviews from william-wang, Thor-wl, and wpeng102 via deada6f June 1, 2021 11:35
@huone1 huone1 force-pushed the optimize-generate-api-way branch from b44f858 to deada6f Compare June 1, 2021 11:35
Signed-off-by: huone1 <huwanxing@huawei.com>
@huone1 huone1 force-pushed the optimize-generate-api-way branch from f426e42 to 1509e1a Compare June 1, 2021 11:56
Copy link
Member

@shinytang6 shinytang6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@william-wang william-wang enabled auto-merge (squash) June 2, 2021 01:20
@william-wang
Copy link
Member

/lgtm
/approve

@william-wang william-wang requested review from william-wang and removed request for william-wang June 2, 2021 01:26
@william-wang william-wang merged commit 0879707 into volcano-sh:master Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants