Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add taskflow crd #51

Closed
wants to merge 1 commit into from
Closed

add taskflow crd #51

wants to merge 1 commit into from

Conversation

hwdef
Copy link
Member

@hwdef hwdef commented Aug 23, 2021 •
edited
Loading

@volcano-sh-bot
Copy link
Collaborator

Welcome @hwdef!

It looks like this is your first PR to volcano-sh/apis 馃帀.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign k82cn
You can assign the PR to them by writing /assign @k82cn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hwdef
add taskflow crd
63c7830 
Signed-off-by: hwdef <hwdefcom@outlook.com>
@k82cn
Copy link
Member

k82cn commented Aug 23, 2021

/hold

Let's start to review this PR after design merged :)

@Thor-wl Thor-wl requested review from k82cn and kevin-wangzefeng and removed request for wpeng102 and Thor-wl August 24, 2021 03:26
@Thor-wl
Copy link
Contributor

Thor-wl commented Aug 24, 2021

/cc @kevin-wangzefeng @k82cn This design has been reviewed at the last three weekly meeting. Because of the api modification, we need your reivew and suggestions.

@hwdef
Copy link
Member Author

hwdef commented Oct 27, 2021

Use other schemes, this crd is no longer needed

@hwdef hwdef closed this Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k82cn k82cn Awaiting requested review from k82cn

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

Assignees
No one assigned
Labels
do-not-merge/hold size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hwdef @volcano-sh-bot @k82cn @Thor-wl