add stable preempt label #68
Conversation
|
Welcome @flyhighzy! |
flyhighzy
force-pushed
the
stablepreempt
branch
from
601d6ed
to
73ee0f8
Compare
| @@ -42,6 +42,9 @@ const QueueNameAnnotationKey = GroupName + "/queue-name" | |||
| // PodPreemptable is the key of preemptable | |||
| const PodPreemptable = "volcano.sh/preemptable" | |||
|
|
|||
| // PodPreemptStableTime is the key of preempt-stable-time, value's unit is second | |||
| const PodPreemptStableTime = "volcano.sh/preempt-stable-time" | |||
There was a problem hiding this comment.
l am ok about the label name, but l prefer to use “ns”, “us”, “ms”, “s”, “m”, “h” as time units
There was a problem hiding this comment.
why do we introduce this label? can we reuse deletiontimestamp?
There was a problem hiding this comment.
why do we introduce this label? can we reuse deletiontimestamp?
this label is used by scheduler to protect these pods not to be preempted in some time, not to make them deleted after some time
There was a problem hiding this comment.
l am ok about the label name, but l prefer to use “ns”, “us”, “ms”, “s”, “m”, “h” as time units
good point, comments updated and I'll add unit support in pr #2149
| @@ -42,6 +42,10 @@ const QueueNameAnnotationKey = GroupName + "/queue-name" | |||
| // PodPreemptable is the key of preemptable | |||
| const PodPreemptable = "volcano.sh/preemptable" | |||
|
|
|||
| // PodPreemptStableTime is the key of preempt-stable-time, value's format "600s","10m" | |||
| // Valid time units are "ns", "us" (or "µs"), "ms", "s", "m", "h". | |||
| const PodPreemptStableTime = "volcano.sh/preempt-stable-time" | |||
There was a problem hiding this comment.
Whether job need a prempt-stable-time as well. If needs, it seems using PreemptStableTime is more reasonable.
Signed-off-by: zhaoying <zhaoying@bilibili.com>
Signed-off-by: zhaoying <zhaoying@bilibili.com>
Signed-off-by: zhaoying <zhaoying@bilibili.com>
flyhighzy
force-pushed
the
stablepreempt
branch
from
2ead720
to
dda06ca
Compare
|
PR is ready, thanks for the advice~ |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Thor-wl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
related to volcano pr #2149 and issue #2075
add a new label "volcano.sh/preempt-stable-time“ to indicate cool down time for preemptees