update jobflow and jobtemplate #78
Conversation
Signed-off-by: zhoumingcheng <zhoumingcheng@beyondcent.com>
|
|
||
| const ( | ||
| // SyncJobFlowAction is the action to sync JobFlow status. | ||
| SyncJobFlowAction Action = "SyncJobFlow" |
There was a problem hiding this comment.
The suffix Action of the parameter names maybe a little bit redundant?
There was a problem hiding this comment.
I define the field, following pkg/apis/bus/v1alpha1/actions.go
There was a problem hiding this comment.
apis/pkg/apis/bus/v1alpha1/actions.go
Line 26 in e23928b
There was a problem hiding this comment.
It's a little issue, not someting matters.
|
/lgtm |
|
@zhoumingcheng BTW, are there any other patches? Or this pr is already completed? |
Nothing to change right now. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Thor-wl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: zhoumingcheng zhoumingcheng@beyondcent.com