Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] develop process for charts related changes? #323

Closed
TommyLike opened this issue Jul 11, 2019 · 11 comments
Closed

[Question] develop process for charts related changes? #323

TommyLike opened this issue Jul 11, 2019 · 11 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@TommyLike
Copy link
Contributor

/kind feature

Background:
Now we have seperated repos for volcano and volcano chart. Considering it's possible that the one feature may change them both at the same time. What is the standard process when developing those features. for example: #165

@TommyLike
Copy link
Contributor Author

One of the solutions that I can think of is:

  1. Develop and Merge functionality codes with UT and existing E2E tests update.
  2. Update charts based on new feature.
  3. Add E2E tests regarding new features and fix issues(if required.)

@k82cn
Copy link
Member

k82cn commented Jul 11, 2019

IMO, we should maintainer Charts in volcano, and sync it to volcano-sh/charts when release.

@volcano-sh-bot volcano-sh-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 11, 2019
@TommyLike
Copy link
Contributor Author

IMO, we should maintainer Charts in volcano, and sync it to volcano-sh/charts when release.

that would be much better.

SrinivasChilveri pushed a commit to SrinivasChilveri/volcano that referenced this issue Jul 11, 2019
Recorded unschedulable event for gang-scheduling.
@TommyLike
Copy link
Contributor Author

IMO, we should maintainer Charts in volcano, and sync it to volcano-sh/charts when release.

So for the convenience of development, should we add the charts code back into volcano repo and sync them into chart repo when releasing? @k82cn @hzxuzhonghu @asifdxtreme ?

NOTE: We may generate release yaml as istio does now for a simpler approach, but it might not conflict to the chart support.

@k82cn
Copy link
Member

k82cn commented Jul 12, 2019

should we add the charts code back into volcano repo and sync them into chart repo when releasing?

Yes, similar to staging pkg in k8s.

@k82cn
Copy link
Member

k82cn commented Jul 14, 2019

so what's our next step?

@TommyLike
Copy link
Contributor Author

so what's our next step?

Sync the latest chart templates into local folder and set up the guidance how and when to sync the latest code back to chart when releasing?

@TommyLike
Copy link
Contributor Author

so what's our next step?

Sync the latest chart templates into local folder and set up the guidance how and when to sync the latest code back to chart when releasing?

Opened a new PR to adding helm charts back #334 . Once again, this is used to reduce the complexity of developing new features. We don't need to open seperated PRs for one feature changes now.

@k82cn
Copy link
Member

k82cn commented Jul 17, 2019

what's next step?

@TommyLike
Copy link
Contributor Author

what's next step?

Update the readme document and setup up the guidance for how & when to sync the templates.

@TommyLike
Copy link
Contributor Author

chart is now in main repo. refer #347 for more requirements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants