same job's diffenrent tasks should compare task's priority #1452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priority plugin's preemptableFn has 2 conditions to preempt: Preemption between Jobs and Preemption between Task within Job; so same job's diffenrent tasks should compare task's priority Signed-off-by: lowang_bh <lhui_wang@163.com>
volcano-sh-bot
added
the
size/S
Thor-wl
approved these changes
May 6, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lowang-bh, Thor-wl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
|
/lgtm |
shinytang6
suggested changes
May 7, 2021
| } else { | ||
| victims = append(victims, preemptee) | ||
| } | ||
| } else { // same job's diffenrent tasks should compare task's priority |
|
/lgtm |
peiniliu
pushed a commit
to peiniliu/volcano
that referenced
this pull request
Aug 27, 2021
…h#1452) priority plugin's preemptableFn has 2 conditions to preempt: Preemption between Jobs and Preemption between Task within Job; so same job's diffenrent tasks should compare task's priority Signed-off-by: lowang_bh <lhui_wang@163.com> Signed-off-by: peiniliu <peini.liu@gmail.com>
This was referenced Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
priority plugin's preemptableFn has 2 conditions to preempt: Preemption between Jobs and Preemption between Task within Job; so same job's diffenrent tasks should compare task's priority
Signed-off-by: lowang_bh lhui_wang@163.com