Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inherit kube-batch owners #281

Merged
merged 1 commit into from
Jul 4, 2019
Merged

Inherit kube-batch owners #281

merged 1 commit into from
Jul 4, 2019

Conversation

k82cn
Copy link
Member

@k82cn k82cn commented Jul 3, 2019 •
edited
Loading

Scheduler is an import part of Volcano, so inherit kube-batch owners. If any comments/suggestions, please let me know :)

@volcano-sh-bot volcano-sh-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 3, 2019
@k82cn
Copy link
Member Author

k82cn commented Jul 3, 2019 •
edited
Loading

@animeshsingh , @hex108 , @hzxuzhonghu , add you into OWNER of Volcano as you're already approver of kube-batch. Please let me know whether that's ok to you :)

@hex108
Copy link
Contributor

hex108 commented Jul 3, 2019

LGTM. Thanks!

@hzxuzhonghu
Copy link
Collaborator

LGTM. thanks

@k82cn
Copy link
Member Author

k82cn commented Jul 4, 2019

Thanks all, I'd like to get this one merged firstly :)

@kevin-wangzefeng
Copy link
Member

kevin-wangzefeng commented Jul 4, 2019 via email •
edited
Loading

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, kevin-wangzefeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [k82cn,kevin-wangzefeng]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TommyLike
Copy link
Contributor

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2019
@volcano-sh-bot volcano-sh-bot merged commit f1630bc into master Jul 4, 2019
kevin-wangzefeng pushed a commit that referenced this pull request Jul 4, 2019
@k82cn
Merge pull request #281 from k82cn/rm_del
665e798 
Removed delete action in addTask.
@k82cn k82cn deleted the add-kube-batch-owners branch July 4, 2019 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

@quinton-hoole quinton-hoole Awaiting requested review from quinton-hoole

Assignees

@TommyLike TommyLike

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. retest-not-required-docs-only size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@k82cn @hex108 @hzxuzhonghu @kevin-wangzefeng @volcano-sh-bot @TommyLike