Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make manifests and add crd about flow.volcano.sh #2874

Merged
merged 1 commit into from Jun 1, 2023
Merged

make manifests and add crd about flow.volcano.sh #2874

merged 1 commit into from Jun 1, 2023

Conversation

lowang-bh
Copy link
Member

@lowang-bh lowang-bh commented May 28, 2023 •
edited

fix #2883 about missing jobflow CRD

  1. add jobflow apis in make manifests
  2. add crd about flow.volcano.sh to config/crd/

Please merge this PR before PR #2882

@volcano-sh-bot volcano-sh-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 28, 2023
@lowang-bh
Copy link
Member Author

/priority important-soon

@volcano-sh-bot volcano-sh-bot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label May 28, 2023
@lowang-bh lowang-bh mentioned this pull request May 28, 2023
Closed
@lowang-bh lowang-bh changed the title fix make manifests; add crd about flow.volcano.sh fix make manifests and add crd about flow.volcano.sh May 29, 2023
@lowang-bh
fix make manifests; add crd about flow.volcano.sh
29b3d64 
Signed-off-by: lowang_bh <lhui_wang@163.com>
This was referenced May 30, 2023
Closed
Closed
Merged
@lowang-bh
Copy link
Member Author

Hi, @wangyang0616 @Thor-wl @hwdef @william-wang Would you please help to review this PR about adding CRD of flow.volcano.sh. Thanks. Please merge it before another PR #2882

hwdef
hwdef reviewed May 30, 2023
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Mostly OK, waiting for approval from other reviewers

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2023
@lowang-bh
Copy link
Member Author

/assign @william-wang

@william-wang william-wang changed the title fix make manifests and add crd about flow.volcano.sh make manifests and add crd about flow.volcano.sh Jun 1, 2023
william-wang
william-wang approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2023
@volcano-sh-bot volcano-sh-bot merged commit 082d372 into volcano-sh:master Jun 1, 2023
13 checks passed
@lowang-bh lowang-bh deleted the jobflowcrd branch June 7, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwdef hwdef hwdef left review comments

@william-wang william-wang william-wang approved these changes

@k82cn k82cn Awaiting requested review from k82cn

@Yikun Yikun Awaiting requested review from Yikun

Assignees

@william-wang william-wang

@hwdef hwdef

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

missing flow.volcano.sh CRD
4 participants
@lowang-bh @volcano-sh-bot @william-wang @hwdef