Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre-install&pre-upgrade hook for admission-init job #3504

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Add pre-install&pre-upgrade hook for admission-init job #3504

merged 2 commits into from
Jun 13, 2024

Conversation

Monokaix
Copy link
Member

@Monokaix Monokaix commented Jun 3, 2024 •
edited
Loading

fix #3496

  1. Set a separate yaml file for volcano admission init job, which will be deleted after install successfully.
  2. Set separate RABC rules for volcano admission init job, and volcano admission doesn't need secrets related permissions.

Also fix part of #3505

@volcano-sh-bot volcano-sh-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 3, 2024
@Monokaix
Add pre-install hook for admission-init job
d7a317d 
Signed-off-by: Monokaix <changxuzheng@huawei.com>
@lowang-bh
Copy link
Member

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2024
@Monokaix Monokaix changed the title Add pre-install hook for admission-init job Add pre-install&pre-upgrade hook for admission-init job Jun 3, 2024
@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2024
@Monokaix Monokaix force-pushed the helm branch 2 times, most recently from ed6c539 to 4bcfc12 Compare June 3, 2024 12:16
@Monokaix
Limit admission permissions
3dace7c 
Signed-off-by: Xuzheng Chang <changxuzheng@huawei.com>
Signed-off-by: Monokaix <changxuzheng@huawei.com>
@Monokaix Monokaix mentioned this pull request Jun 5, 2024
Closed
william-wang
william-wang approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2024
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2024
@volcano-sh-bot volcano-sh-bot merged commit 0a560f6 into volcano-sh:master Jun 13, 2024
14 checks passed
@Monokaix Monokaix deleted the helm branch July 26, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@william-wang william-wang william-wang approved these changes

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

@yuanchen8911 yuanchen8911 Awaiting requested review from yuanchen8911

Assignees

@william-wang william-wang

@lowang-bh lowang-bh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm: 1.8.2 -> 1.9.0 upgrade breaks
4 participants
@Monokaix @lowang-bh @volcano-sh-bot @william-wang