Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose volcano components (controller, scheduler, etc.) log level control to the helm chat values #3656

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Expose volcano components (controller, scheduler, etc.) log level control to the helm chat values #3656

merged 1 commit into from
Aug 16, 2024

Conversation

chenshiwei-io
Copy link
Contributor

Expose volcano components (controller, scheduler, etc.) log level control to the helm chat values
#3619

@volcano-sh-bot
Copy link
Contributor

Welcome @chenshiwei-io!

It looks like this is your first PR to volcano-sh/volcano.

Thank you, and welcome to Volcano. 😃

@chenshiwei-io chenshiwei-io changed the title Feature/log level Expose volcano components (controller, scheduler, etc.) log level control to the helm chat values Aug 6, 2024
@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 6, 2024
@chenshiwei-io
Copy link
Contributor Author

hello, please help me review the pr. thanks

hwdef
hwdef reviewed Aug 6, 2024
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

Thanks for your contributions!

@volcano-sh-bot volcano-sh-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. labels Aug 6, 2024
@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2024
hwdef
hwdef reviewed Aug 7, 2024
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2024
@Monokaix
Copy link
Member

Monokaix commented Aug 9, 2024

Hi, you can use git commit --ame --no-edit -s and for push again to retest.

@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2024
@chenshiwei-io
Copy link
Contributor Author

Hi, you can use git commit --ame --no-edit -s and for push again to retest.

It's done

@Monokaix
Copy link
Member

Please squash to one commit.

@chenshiwei-io
feat: allow Admission, Controller, Scheduler log print level setting …
e6c7a08 
…in chart value

Signed-off-by: chenshiwei-io <buzoumei@gmail.com>
@chenshiwei-io
Copy link
Contributor Author

Please squash to one commit.

I got it done.

william-wang
william-wang approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2024
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2024
@volcano-sh-bot volcano-sh-bot merged commit d16bb32 into volcano-sh:master Aug 16, 2024
14 checks passed
@chenshiwei-io
Copy link
Contributor Author

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwdef hwdef hwdef left review comments

@william-wang william-wang william-wang approved these changes

@huone1 huone1 Awaiting requested review from huone1

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

@Monokaix Monokaix Awaiting requested review from Monokaix

Assignees

@william-wang william-wang

@hwdef hwdef

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chenshiwei-io @volcano-sh-bot @Monokaix @william-wang @hwdef