Add command vjobs, vqueues and unit tests. #666
Conversation
Signed-off-by: jiangkaihua <54176503+jiangkaihua@users.noreply.github.com>
volcano-sh-bot
added
the
size/XXL
|
Hey @jiangkaihua, TravisBuddy Request Identifier: a33cf0d0-36d7-11ea-a8cf-c90382c1967d |
| @@ -96,3 +96,5 @@ command-lines: | |||
| go build -ldflags ${LD_FLAGS} -o=${BIN_DIR}/vcancel ./cmd/cli/vcancel | |||
| go build -ldflags ${LD_FLAGS} -o=${BIN_DIR}/vresume ./cmd/cli/vresume | |||
| go build -ldflags ${LD_FLAGS} -o=${BIN_DIR}/vsuspend ./cmd/cli/vsuspend | |||
| go build -ldflags ${LD_FLAGS} -o=${BIN_DIR}/vjobs ./cmd/cli/vjobs | |||
| go build -ldflags ${LD_FLAGS} -o=${BIN_DIR}/vqueues ./cmd/cli/vqueues | |||
There was a problem hiding this comment.
Why do we need so many cli?
There was a problem hiding this comment.
They are simliar to Slurm cli like squeue, scancel, so that Slurm user would get used to our cli more easliy.
There was a problem hiding this comment.
I donot think so. If you make each command a binary, it will definitely be inflated. And it will enforce users to install more tools and remember all.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiangkaihua, k82cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
Signed-off-by: jiangkaihua 54176503+jiangkaihua@users.noreply.github.com