Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add golangci-lint to project #799

Merged
merged 1 commit into from
May 10, 2020
Merged

add golangci-lint to project #799

merged 1 commit into from
May 10, 2020

Conversation

masihtehrani
Copy link
Contributor

fix #792

@volcano-sh-bot
Copy link
Contributor

Welcome @masihtehrani!

It looks like this is your first PR to volcano-sh/volcano 馃帀.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot volcano-sh-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. labels May 8, 2020
@volcano-sh-bot volcano-sh-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 8, 2020
@TravisBuddy
Copy link

Travis tests have failed

Hey @masihtehrani,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 7da71da0-9140-11ea-ba10-7b1b65697aa0

@k82cn
Copy link
Member

k82cn commented May 9, 2020

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, masihtehrani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2020
@k82cn
Copy link
Member

k82cn commented May 9, 2020

That's great to improve golint! Let's get it merged when CI happy with that :)

@volcano-sh-bot volcano-sh-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 10, 2020
@masihtehrani masihtehrani marked this pull request as ready for review May 10, 2020 01:46
@volcano-sh-bot volcano-sh-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 10, 2020
@masihtehrani
add golangci-lint to project
97f8895 
fix volcano-sh#792

Signed-off-by: Mahmoud <mahmud.tehrani@gmail.com>
@volcano-sh-bot
Copy link
Contributor

Keywords which can automatically close issues and at(@) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

  • 97f8895 add golangci-lint to project

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@masihtehrani
Copy link
Contributor Author

/lgtm

@volcano-sh-bot
Copy link
Contributor

@masihtehrani: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k82cn
Copy link
Member

k82cn commented May 10, 2020

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2020
@volcano-sh-bot volcano-sh-bot merged commit bab40f1 into volcano-sh:master May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzxuzhonghu hzxuzhonghu Awaiting requested review from hzxuzhonghu

@yuanchen8911 yuanchen8911 Awaiting requested review from yuanchen8911

Assignees

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable more linter checks
4 participants
@masihtehrani @volcano-sh-bot @TravisBuddy @k82cn