Skip to content

Commit c3f63eb

Browse files
authored
[misc] fix: set default value of ETP to 1 (#3371)
### What does this PR do? As title ### Checklist Before Starting - [ ] Search for similar PRs. Paste at least one query link here: ... - [ ] Format the PR title as `[{modules}] {type}: {description}` (This will be checked by the CI) - `{modules}` include `fsdp`, `megatron`, `sglang`, `vllm`, `rollout`, `trainer`, `ci`, `training_utils`, `recipe`, `hardware`, `deployment`, `ray`, `worker`, `single_controller`, `misc`, `perf`, `model`, `algo`, `env`, `tool`, `ckpt`, `doc`, `data` - If this PR involves multiple modules, separate them with `,` like `[megatron, fsdp, doc]` - `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test` - If this PR breaks any API (CLI arguments, config, function signature, etc.), add `[BREAKING]` to the beginning of the title. - Example: `[BREAKING][fsdp, megatron] feat: dynamic batching` ### Test > For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc. ### API and Usage Example > Demonstrate how the API changes if any, and provide usage example(s) if possible. ```python # Add code snippet or script demonstrating how to use this ``` ### Design & Code Changes > Demonstrate the high-level design if this PR is complex, and list the specific changes. ### Checklist Before Submitting > [!IMPORTANT] > Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review. - [ ] Read the [Contribute Guide](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md). - [ ] Apply [pre-commit checks](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting): `pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=always` - [ ] Add / Update [the documentation](https://github.com/volcengine/verl/tree/main/docs). - [ ] Add unit or end-to-end test(s) to [the CI workflow](https://github.com/volcengine/verl/tree/main/.github/workflows) to cover all the code. If not feasible, explain why: ... - [ ] Once your PR is ready for CI, send a message in [the `ci-request` channel](https://verl-project.slack.com/archives/C091TCESWB1) in [the `verl` Slack workspace](https://join.slack.com/t/verl-project/shared_invite/zt-3855yhg8g-CTkqXu~hKojPCmo7k_yXTQ). (If not accessible, please try [the Feishu group (飞书群)](https://applink.larkoffice.com/client/chat/chatter/add_by_link?link_token=772jd4f1-cd91-441e-a820-498c6614126a).)
1 parent f346f96 commit c3f63eb

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

tests/special_e2e/run_ppo_trainer_megatron.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ COMMON_VPP=${COMMON_VPP:-2}
5858
COMMON_CP=${COMMON_CP:-2}
5959
COMMON_TP=${COMMON_TP:-2}
6060
COMMON_EP=${COMMON_EP:-1}
61-
COMMON_ETP=${COMMON_ETP:-null}
61+
COMMON_ETP=${COMMON_ETP:-1}
6262

6363
TRAIN_TP=${TRAIN_TP:-$COMMON_TP}
6464
INFER_TP=${INFER_TP:-$COMMON_TP}

verl/trainer/config/_generated_ppo_megatron_trainer.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ actor_rollout_ref:
3333
optimizer_offload: false
3434
tensor_model_parallel_size: 1
3535
expert_model_parallel_size: 1
36-
expert_tensor_parallel_size: null
36+
expert_tensor_parallel_size: 1
3737
pipeline_model_parallel_size: 1
3838
virtual_pipeline_model_parallel_size: null
3939
context_parallel_size: 1
@@ -155,7 +155,7 @@ actor_rollout_ref:
155155
optimizer_offload: false
156156
tensor_model_parallel_size: 1
157157
expert_model_parallel_size: 1
158-
expert_tensor_parallel_size: null
158+
expert_tensor_parallel_size: 1
159159
pipeline_model_parallel_size: 1
160160
virtual_pipeline_model_parallel_size: null
161161
context_parallel_size: 1
@@ -325,7 +325,7 @@ critic:
325325
optimizer_offload: false
326326
tensor_model_parallel_size: 1
327327
expert_model_parallel_size: 1
328-
expert_tensor_parallel_size: null
328+
expert_tensor_parallel_size: 1
329329
pipeline_model_parallel_size: 1
330330
virtual_pipeline_model_parallel_size: null
331331
context_parallel_size: 1

verl/trainer/config/engine/megatron.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ tensor_model_parallel_size: 1
1717
expert_model_parallel_size: 1
1818

1919
# expert tensor parallel size
20-
expert_tensor_parallel_size: null
20+
expert_tensor_parallel_size: 1
2121

2222
# pipeline model parallel size
2323
pipeline_model_parallel_size: 1

0 commit comments

Comments
 (0)