Rescue failed gallery upload

[rzane]

When a file failed to upload to a gallery, the loading icon would just sit there spinning. The error wasn't being caught. The imageUploadFailed function was added because the error behavior was used in multiple places. The problem can be replicated by attempting to upload a file with a strange extension.

After handling the errors, the refresh button wasn't being hidden after being clicked. Every time it was clicked, it would refetch the images without clearing the images that were already there.

Also, as far as I know, there's no reason to use class_eval inside the included block when using ActiveSupport::Concern. The included block is for class level macros, like has_one or attr_accessor. No need to put instance methods in the included block.

[coveralls]

Coverage decreased (-0.01%) to 94.82% when pulling 869968c on rzane:catch-gallery-upload-errors into 59105dd on volmer:master.

[volmer]

Good catch! This is a very good improvement. And you're totally right about ActiveSupport::Concern too. Can I ask you to just add a Cucumber scenario to cover the error handling?

Thanks a million times for this PR! 👍

[coveralls]

Coverage increased (+0.25%) to 95.08% when pulling 60334cf on rzane:catch-gallery-upload-errors into 59105dd on volmer:master.

[rzane]

Hey @volmer, any reason this hasn't been merged yet?

[volmer]

Amazing work, @rzane. Sorry for the delay, I wasn't aware you've updated it. Could you please fix the conflicts so I can proceed with the merge?

[rzane]

Absolutely. I'll rebase asap.

[coveralls]

Coverage increased (+0.26%) to 95.09% when pulling 73491c5 on rzane:catch-gallery-upload-errors into dea651d on volmer:master.

[rzane]

I can squash my commits if you'd prefer. This should merge cleanly now.

In my most recent commit, I removed update from the routes, since it wasn't in use. I also added a config option for Bootsy.base_controller. Setting it to ApplicationController would allow users to control authentication more easily.

[coveralls]

Coverage increased (+0.26%) to 95.09% when pulling de4a9c8 on rzane:catch-gallery-upload-errors into dea651d on volmer:master.

[volmer]

Thank you for the hard work! ❤️