Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tiny] Remove Package Hooks under new install workflow #817

Merged
merged 1 commit into from
Sep 11, 2020
Merged

[Tiny] Remove Package Hooks under new install workflow #817

merged 1 commit into from
Sep 11, 2020

Conversation

charlespierce
Copy link
Contributor

@charlespierce charlespierce commented Sep 9, 2020 •
edited
Loading

Info

  • Part 6 of package rework: Remove the unused Package hooks under the new workflow
  • Since we are now delegating to npm install --global to handle package installs, we no longer want to have a hybrid Hooks & .npmrc method for redirecting the download.
    • Even before the change, Package hooks were soft-deprecated and didn't fully work as expected
    • With the new workflow, we can cleanly remove them and rely only on the .npmrc files used by the package manager.

Changes

  • Marked the Package hook kinds as only available without the feature flag enabled.

Tested

  • Confirmed that Volta compiles without warnings or errors both with and without the feature flag.

@charlespierce charlespierce mentioned this pull request Sep 9, 2020
Merged
mikrostew
mikrostew approved these changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@mikrostew mikrostew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So excited for this work to land

@charlespierce charlespierce marked this pull request as ready for review September 11, 2020 01:27
@charlespierce charlespierce merged commit 5686911 into volta-cli:main Sep 11, 2020
@charlespierce charlespierce deleted the remove_package_hooks branch September 11, 2020 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikrostew mikrostew mikrostew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charlespierce @mikrostew