Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move modules to their conventional locations #849

Merged
merged 1 commit into from
Oct 2, 2020

Conversation

charlespierce
Copy link
Contributor

@charlespierce charlespierce commented Oct 2, 2020

Follow-up to #848 - Move the new package global modules (run and tool::package) to their conventional locations and remove the need for #[path] attributes.

This is separated to make the diff easier to parse, since the previous PR removes the directories that were at those locations.

To see only the changes from this PR (much nicer than the combined), use this link

Copy link
Contributor

@chriskrycho chriskrycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@chriskrycho chriskrycho merged commit f675514 into volta-cli:main Oct 2, 2020
@charlespierce charlespierce deleted the move_modules branch October 12, 2020 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants