Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move back to attohttpc, now that it supports proxies #851

Merged
merged 1 commit into from
Oct 13, 2020

Conversation

charlespierce
Copy link
Contributor

Info

  • In Switch to reqwest for proxy support #809, we switched to reqwest for handling HTTP requests to support proxies via HTTP_PROXY and HTTPS_PROXY environment variables.
  • However, that change came with an increase in build time and binary size, since reqwest is a much larger library than attohttpc.
  • Additionally, reqwest currently doesn't support the NO_PROXY environment variable for carving out exceptions to the proxy environment.
  • attohttpc recently (with version 0.16.0) added support for proxies, including the NO_PROXY environment variable.

Changes

Tested

  • All existing automated tests work.
  • Local testing to confirm that proxy environment variables are supported.
  • Local testing to confirm that NO_PROXY is respected as well.

Copy link
Contributor

@chriskrycho chriskrycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice reversion, quick turnaround on this thing. I like it!

@charlespierce charlespierce merged commit 12155aa into volta-cli:main Oct 13, 2020
@charlespierce charlespierce deleted the attohttpc_with_proxy branch October 13, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants