Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for configuration files for custom packages not installed… #484

Merged
merged 1 commit into from
Feb 11, 2021

Conversation

ashthespy
Copy link
Collaborator

… during rootfs creation

Fixes #479

PS: Can't test ATM but should work in theory.

@volumio
Copy link
Owner

volumio commented Feb 11, 2021

That's not going to fix the issue... We have the same issue with shairport...

@ashthespy
Copy link
Collaborator Author

Hmm, currently we use upstream shairport, so it's pulled in via multistrap. When you add the custom version, you could copy it's service file here similarly as well? If you blanket copy all the service files you would have to test to ensure other issues don't crop up. If you ask me, this is the least effort solution to fast track things. I unfortunately currently don't have the time now to refactor things as discussed in #479

@volumio volumio merged commit d87c5a8 into volumioOS Feb 11, 2021
@volumio volumio deleted the delayed_config branch February 11, 2021 19:47
@volumio
Copy link
Owner

volumio commented Feb 11, 2021

@ashthespy ok let's implement this workaround since you don't have time, good suggestion ;)

@ashthespy ashthespy mentioned this pull request Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants