Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo: bump version-sync dependency #1

Merged
merged 1 commit into from
Mar 30, 2019
Merged

Conversation

mgeisler
Copy link
Contributor

The new version 0.8.0 requires Rust 2018, which this project is already using.

@vorner
Copy link
Owner

vorner commented Mar 29, 2019

Hello

Thank you for the PR and I'd be more than happy to accept it, but it seems the builds are not working. Can you have a look what went wrong? It seems to be related to that dependency bump.

@mgeisler
Copy link
Contributor Author

Sure, I'll have a look!

The new version 0.8.0 requires Rust 2018, which this project is already using.
@mgeisler
Copy link
Contributor Author

Done, it turned out that I simply needed to bump the dependency in both projects :-)

@vorner vorner merged commit 3e941ba into vorner:master Mar 30, 2019
@vorner
Copy link
Owner

vorner commented Mar 30, 2019

Thank you :-)

As this is a dev-dependency only that has no effect on downstream crates, I'll not create a new release because of that but bundle it with whatever future release comes.

@mgeisler
Copy link
Contributor Author

Yeah, makes perfect sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants