Remove Send + Sync bounds
#8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original `tar` crate imposes no such requirement. And neither does `async_tar`: https://docs.rs/async-tar/0.4.2/src/async_tar/archive.rs.html#27 In most cases in our test code we're working with owned values, which will meet these bounds. But I'm working on a library which does some dynamic computation of e.g. compression or other things, and I don't want to impose `Send + Sync` bounds across everything up the stack there.
cgwalters
force-pushed
the
remove-sync-bound
branch
from
9407c6c
to
35caf04
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original
tarcrate imposes no such requirement. And neitherdoes
async_tar: https://docs.rs/async-tar/0.4.2/src/async_tar/archive.rs.html#27In most cases in our test code we're working with owned values,
which will meet these bounds.
But I'm working on a library which does some dynamic computation of e.g.
compression or other things, and I don't want to impose
Send + Syncbounds across everything up the stack there.