Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in VorpleStopSoundEffects and VorpleStopAudio breaks these functions #32

Closed
joshwarecom opened this issue Jun 5, 2021 · 0 comments

Comments

@joshwarecom
Copy link

The following code in vorple-multimedia.h does not stop looping sound effects as expected:

[ VorpleStopSoundEffects ;
    VorpleExecuteJavaScriptCommand("$('.vorple-sound').remove()");
];
[ VorpleStopAudio ;
    VorpleExecuteJavaScriptCommand("$('.vorple-sound').remove();vorple.audio.stopMusic()");
];

Suggested root cause:
".vorple-sound" should probably be ".vorple-sound-effect" in both functions, when I make that change, the functions work as expected and stop the looping sound effects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants