Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable automatic prompt hook registration #48

Closed

Conversation

cspotcode
Copy link
Contributor

I added a flag to disable automatic registration of the prompt hook. It's only for advanced situations. You do something like this in your $PROFILE:

Import-Module ZLocation -ArgumentList @{Register = $false}

@cspotcode cspotcode mentioned this pull request Aug 25, 2018
@glucas
Copy link

glucas commented Aug 27, 2018

I'd drop the Write-Host, or change it to use Write-Information (or Write-Verbose?). Right now using this with cmder I get "False" printed in every new shell and there's no straightforward way to suppress it.

@cspotcode
Copy link
Contributor Author

@glucas Agreed; that was debugging code that I didn't mean to commit.

@vors
Copy link
Owner

vors commented Sep 7, 2018

@cspotcode thank you for taking a stab at it! I think cmdler is unique enough case that we should just handle it gracefully ourselves without a separate user instruction. I don't plan to merge this PR and will close it in favor of the explicit cmder hanlding at some point. If you have windows machine with cmder around, feel free to update this PR!

@vors
Copy link
Owner

vors commented Sep 8, 2018

Closing in favour of eb69bb5

@vors vors closed this Sep 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants