-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
Default readme language is english, but a new readme file in portuguese was created, and both files have a link between each other
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments
readme.md
Outdated
|
||
- Css files have cache buster (no header.php); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- A cache buster is enabled for CSS files (in the
header.php
file);
readme.md
Outdated
- **classic editor** - para o editor funcionar (s/ guttenberg) | ||
- **wp bakery** - para a criação de posts com templates personalizados. | ||
- tema criado de raiz para a VOST /vost | ||
Actual version: wp 5.1.1, com plugins wpml, acf, wp bakery, classic editor e acf extended forms instalados. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current version: WordPress 5.1.1, with the following plugins installed: WPML, ACF, WPBakery, Classic Editor and ACF extended forms.
readme.md
Outdated
|
||
encontra-se em */wp-content/themes/vost/dev* | ||
The production environment is made to work with GULP, SASS, Babel, and image optimization. You can work without this, but the production files are minified. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GULP
-> gulp
readme.md
Outdated
- Mailchimp integrated newsletter; | ||
- Archive page; | ||
- Global header/footer info, to make less calls to database; | ||
- Disable jquery global loading, and keep only in home for slickjs (try to optimize as much as possible). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jquery
-> jQuery
readme.md
Outdated
|
||
- htaccess cache for imagens/static; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
htaccess
-> .htaccess
readme.md
Outdated
- Menu edition in apresentação > menus; | ||
- Footer columns edition in apresentação > widgets; | ||
- Duplicate posts to English (and info); | ||
- In functions.php exists a snippet that removes functions for editors; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- There's a code snippet in the
functions.php
file that disables editor functionality;
(not sure what the original sentence meant, I assume the above)
readme.md
Outdated
- Css files have cache buster (no header.php); | ||
- If, for some reason wpml is disabled, you must pay attention all called instances; | ||
- The same for acf, but you would have noticed :) ; | ||
- jquery is only needed for slickjs in home (optimization tip - call script only in home, it's already called in functions); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jquery
-> jQuery
@quetzyg Thanks for your feedback! I've corrected readme with all your suggestions, and will submit a new commit soon. About your comment referring to line 53, I'm not the original author, so I've tried to translate this readme without changing the meaning of the phrases, but since I agreed with you, this note was also modified. |
In both en and pt files, as suggested by @quetzyg
readme.md - English version
readme.pt.md - Portuguese version