Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Occurrences Widget - On Site Help #21

Closed
Vanethos opened this issue Aug 14, 2019 · 10 comments · Fixed by #86
Closed

Occurrences Widget - On Site Help #21

Vanethos opened this issue Aug 14, 2019 · 10 comments · Fixed by #86
Assignees
Labels
good first issue Good for newcomers hacktoberfest Hacktoberfest is here! Don't know which issues you should choose? Pick these!

Comments

@Vanethos
Copy link
Contributor

Vanethos commented Aug 14, 2019

Description
Separate widget for the "On Site Help" of the Occurrences.

File Location

- presentation
|__ ui

Requirements

  • Widget that with the Occurrences object displays information about:

    • The means that are on the site, be it human, land or aerial
    • Last update
  • This widget must have a callback for the click on the map image, so that the details screen can show the Map screen with the marker centered on it

UI

imagem

NOTES
Until the API Is completed, assume that this widget has as an input 1 DateTime object and 3 int.

@OldMetalmind OldMetalmind added this to the v1.0.0 - Akita milestone Aug 16, 2019
@OldMetalmind OldMetalmind added the good first issue Good for newcomers label Aug 24, 2019
@Vanethos Vanethos added the hacktoberfest Hacktoberfest is here! Don't know which issues you should choose? Pick these! label Sep 20, 2019
@hientranea
Copy link

@Vanethos Can i work on this issue ?

@Vanethos
Copy link
Contributor Author

Vanethos commented Oct 6, 2019

Yes!

I'll assign this issue to you

@Vanethos
Copy link
Contributor Author

@hientranea any news on this issue?

@TomerPacific
Copy link
Contributor

@Vanethos, do you need help with this issue?

@Vanethos
Copy link
Contributor Author

Hey @TomerPacific !

Sure! I don't have access to the images yet but you can use one of logos in the assets folder

I'll assign this to you

@Vanethos Vanethos assigned TomerPacific and unassigned hientranea Oct 21, 2019
@TomerPacific
Copy link
Contributor

@Vanethos ,
below is a screenshot of what I have so far:

app

I have turned the background black so that the image asset can be shown (as it is white). I am also aware of the font size and will scale it accordingly.

I wanted to get some clarification about the callback. If you could provide some more detail on how it should work, that would help me code it. As of this moment, I do not understand how this callback works. To what do I attach it? As described it is not passed in the constructor.

Furthermore, I have taken the liberty to move the dateFormatter method, getFormattedDate, to the misc class inside the utils. I have done this, since this widget also needs to format the dateTime object. Let me know if this ok.

@Vanethos
Copy link
Contributor Author

@TomerPacific the callback should be ignored for now, it is something that must be done after all these widgets are created.

Having the formatted date in another class is brilliant, thanks for that 👍

As with the previous widget that you have worked on, will this wrap nicely in a small card like we see in the original Post? What I mean is: If I use your item in a list, how will it look?

Also:

  • The text is too large, please see the original post for a comparison
  • The images are not aligned with the text: the first image is centered on the "Humanos" text while the "AEREOS" image is before the text, maybe instead of two rows uyou should use a row with 3 columns, one for each combo of image/text

@TomerPacific
Copy link
Contributor

TomerPacific commented Oct 21, 2019

@Vanethos , thanks for the quick reply.
I will ignore the callback. As I mentioned, I am aware of the text size and will scale it. I just wanted to put a screenshot so you can get an idea of what I am working on.

It is supposed to wrap nicely as I have wrapped everything in a Container widget.
In regards to alignment, the layout of the widget is:

Material
|
Container
|
Column
| | |
Row Row Row
|
Column
|
Container
|
Row

The reason it is mapped this way is because I needed to have the image and the text in the same row. It does not align, as some rows/columns have the mainAxisSize attribute set with spaceEvenly.
I will work to align all the items accordingly.

-- UPDATE --
I have reorganized the layout and it now looks like so:

app

@Vanethos
Copy link
Contributor Author

Now with the update it's perfect 👍

@TomerPacific
Copy link
Contributor

@Vanethos , I have created a PR

Vanethos added a commit that referenced this issue Oct 27, 2019
Feature: On Site Help Widget Implementation (#21)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest Hacktoberfest is here! Don't know which issues you should choose? Pick these!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants