Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for custom/different word lists per generate request. #7

Merged
merged 1 commit into from Mar 22, 2018
Merged

Adding support for custom/different word lists per generate request. #7

merged 1 commit into from Mar 22, 2018

Conversation

jbueler
Copy link

@jbueler jbueler commented Mar 6, 2018

No description provided.

@vot vot self-requested a review March 8, 2018 22:44
@stevearoonie
Copy link

I was about to do something similar. This would be good to have in.

@vot vot changed the base branch from master to custom-word-list March 22, 2018 09:39
@vot
Copy link
Owner

vot commented Mar 22, 2018

Hi @jbueler and @stevearoonie,

I'm going to merge this into a separate branch and make a couple of small changes there.
Just a tiny coding convention adjustment I mentioned in PR review and will see if I can expose it in a sensible way through CLI.

This will likely be published on npm in a couple of days.

@vot vot merged commit 0302397 into vot:custom-word-list Mar 22, 2018
@vot
Copy link
Owner

vot commented Mar 22, 2018

@jbueler, @stevearoonie:

You can see the updates here:
https://github.com/vot/xkpasswd-node/compare/custom-word-list
It's still quick and dirty so will need a cleanup and some tests to cover this new functionality.

Anyway this will allow the wordList option to be specified through CLI or programmatically as:

  • JSON file
  • text file
  • an array of strings
  • a string with individual words separated by commas

In addition the list will be cleaned up on the fly to ensure no spaces are introduced as well as remove empty strings.

Thanks for providing the base for this work @jbueler, much appreciated.
Hopefully this will cover all typical scenarios.

@stevearoonie
Copy link

Thanks a lot @vot and @jbueler. I appreciate your work.

@jbueler
Copy link
Author

jbueler commented Mar 27, 2018

Hey this is great, thanks for incorporating this feature. You did a much better job, more thought out. Thanks for your work on this module!

@jbueler jbueler deleted the custom-word-list branch March 27, 2018 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants