Skip to content
This repository has been archived by the owner on May 26, 2021. It is now read-only.

Switch to cmake buildsystem #3

Merged
merged 14 commits into from
Jul 24, 2017
Merged

Switch to cmake buildsystem #3

merged 14 commits into from
Jul 24, 2017

Conversation

junghans
Copy link
Member

Still not a pure cmake buildsystem, but much less hacky than the old make-based system.

Needed for votca/votca#2

@junghans junghans self-assigned this Jul 24, 2017
@junghans junghans requested a review from jkrajniak July 24, 2017 03:37
Copy link
Member

@jkrajniak jkrajniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've built it on my own machine and it seems to work correctly although I am not too strong of CMake to add valuable comment on the code itself.

CMakeLists.txt Outdated
include(GNUInstallDirs)

if(CMAKE_SOURCE_DIR STREQUAL CMAKE_BINARY_DIR)
message(FATAL_ERROR "In-source build not supported with UseLATEX.cmake")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add here some hint what to do, like mkdir build; cd build; cmake ..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thanks!

@junghans junghans merged commit 870175b into master Jul 24, 2017
@junghans junghans deleted the cmake branch July 24, 2017 14:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants