Skip to content
This repository has been archived by the owner on Sep 27, 2021. It is now read-only.

Piece wise beadmotif #468

Merged
merged 12 commits into from
Dec 10, 2019
Merged

Piece wise beadmotif #468

merged 12 commits into from
Dec 10, 2019

Conversation

JoshuaSBrown
Copy link
Contributor

Changed from using pointer to reference
Added const noexcept keywords with appropriate methods
Added pragma once to header file
Changed include from global path to relative

Copy link
Member

@JensWehner JensWehner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Dec 9, 2019

Codecov Report

Merging #468 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #468   +/-   ##
=====================================
  Coverage      61%    61%           
=====================================
  Files         128    128           
  Lines        6299   6299           
=====================================
  Hits         3846   3846           
  Misses       2453   2453
Flag Coverage Δ
#gcc 61% <100%> (ø) ⬆️
Impacted Files Coverage Δ
include/votca/csg/beadmotif.h 100% <ø> (ø) ⬆️
include/votca/csg/beadstructure.h 92.7% <ø> (ø) ⬆️
src/libcsg/beadmotif.cc 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7181e9...6955fa1. Read the comment docs.

@junghans junghans merged commit 0118440 into master Dec 10, 2019
@junghans junghans deleted the piece-wise-beadmotif branch December 10, 2019 02:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants