Piece wise beadmotifconnector

[JoshuaSBrown]

Used pragma once
Const correctness applied
Improved testing
noexcept keyword added where appropriate
assertion test added in appropriate method

[codecov]

Codecov Report

Merging #475 into master will increase coverage by <.1%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master    #475     +/-   ##
========================================
+ Coverage    61.1%   61.1%   +<.1%     
========================================
  Files         129     129             
  Lines        6321    6322      +1     
========================================
+ Hits         3868    3869      +1     
  Misses       2453    2453

Flag	Coverage Δ
#gcc	61.1% <100%> (ø)	⬆️

Impacted Files	Coverage Δ
include/votca/csg/beadmotifconnector.h	100% <ø> (ø)	⬆️
src/libcsg/beadmotifconnector.cc	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57b6fea...25bf815. Read the comment docs.

[JoshuaSBrown]

@JensWehner hey can you take a look when you get the chance?

[junghans]

Why?

[JoshuaSBrown]

I believe it is a better practice. For instance if you build the project and it has previously installed it can link to the wrong files.

[JoshuaSBrown]

It is safer to reserve global reference for the other repositories, and use the relative include paths internally, it doesn't look as nice though.

[junghans]

I think it doesn't hurt, we add the local include path here anyhow:
https://github.com/votca/csg/blob/master/src/libcsg/CMakeLists.txt#L32

[JoshuaSBrown]

My wording is probably a bit off, <> notation looks somewhere on the system, whereas "" will look in the current repo.

[JoshuaSBrown]

I have had issues with this in the past but I am not sure if they were before or after those lines were placed in the cmake file.

[junghans]

@JensWehner please review

[JoshuaSBrown]

Ping @JensWehner