Skip to content
This repository has been archived by the owner on Sep 27, 2021. It is now read-only.

Fix includes #487

Merged
merged 6 commits into from
Dec 21, 2019
Merged

Fix includes #487

merged 6 commits into from
Dec 21, 2019

Conversation

JoshuaSBrown
Copy link
Contributor

Changed system includes to local includes, this prevents issues that occur during compile time. E.g. if a header file is deleted in a new pull request but the header file is included in some of the source files in the pull request. In such a case, no errors will be seen if tested locally as the compiler will still find the file in the system includes. By building with what is in the local repo you avoid false positive builds.

@codecov
Copy link

codecov bot commented Dec 21, 2019

Codecov Report

Merging #487 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #487   +/-   ##
======================================
  Coverage    61.1%   61.1%           
======================================
  Files         129     129           
  Lines        6322    6322           
======================================
  Hits         3869    3869           
  Misses       2453    2453
Flag Coverage Δ
#gcc 61.1% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/libcsg/version.cc 100% <ø> (ø) ⬆️
src/tools/csg_fmatch.cc 79.1% <ø> (ø) ⬆️
src/csg_boltzmann/tabulatedpotential.cc 62.9% <ø> (ø) ⬆️
src/tools/csg_fmatch.h 100% <ø> (ø) ⬆️
src/tools/csg_stat.cc 100% <ø> (ø) ⬆️
src/libcsg/modules/io/xyzreader.cc 4.3% <ø> (ø) ⬆️
src/tools/csg_gmxtopol.cc 21.3% <ø> (ø) ⬆️
src/libcsg/nematicorder.cc 3.2% <ø> (ø) ⬆️
src/libcsg/topologyreader.cc 100% <ø> (ø) ⬆️
src/libcsg/modules/io/gmxtopologyreader.h 100% <ø> (ø) ⬆️
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ba213b...799016b. Read the comment docs.

@junghans junghans merged commit f7903ee into master Dec 21, 2019
@junghans junghans deleted the fix-includes branch December 21, 2019 23:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants