Remove xtp/share/package folder

[felipeZ]

The problem

Currently there are two folder where XTP stores configuration files:

share/packages
share/xtp/xml

The content of the first folder is installed at ${VOTCASHARE}/votca/xtp/packages and the second to
${VOTCASHARE}/votca/xtp/xml

Both the actual source path and the installation path are used in different parts for configuration, installation, running the CI and running the actual calculation by the user.
These paths are the cause of many misconfigurations and problems calling the runners.

For example, the votca_xtp target properties are set like:

get_filename_component(_PARENT_PATH "${CMAKE_CURRENT_BINARY_DIR}" DIRECTORY)

add_library(votca_xtp  ${VOTCA_SOURCES})
set_target_properties(votca_xtp PROPERTIES SOVERSION ${SOVERSION})
set_target_properties(votca_xtp PROPERTIES VOTCA_SHARE ${CMAKE_SOURCE_DIR}/xtp/share)
set_target_properties(votca_xtp PROPERTIES XTP_PATH ${_PARENT_PATH}/tools)

The VOTCA_SHARE variable is pointing correctly to the calculators configuration but erroneously to the package path.

The solution

Move the content of share/packages into share/xtp/xml.

TODO

• move the xml files from one folder to the other
• fix all the broken path invoking the calculator
• fix the documentation generation
• fix the target used by script calling the Jupyter notebooks in the CI

[JensWehner]

sounds good.