Skip to content
This repository has been archived by the owner on Sep 28, 2021. It is now read-only.

Addressed missing includes #452

Merged
merged 5 commits into from
May 23, 2020
Merged

Conversation

JoshuaSBrown
Copy link
Contributor

@JoshuaSBrown JoshuaSBrown commented May 22, 2020

This is to fix the problem of inheriting includes from tools, votca/tools#246.
Addressed deepcode warnings.

@ghost
Copy link

ghost commented May 22, 2020

DeepCode's analysis on #79fc1a found:

⚠️ 1 warning

👉 View analysis in DeepCode’s Dashboard

☺️ If you want to provide feedback on our bot, here is how to contact us.

@codecov
Copy link

codecov bot commented May 22, 2020

Codecov Report

Merging #452 into master will decrease coverage by 0.0%.
The diff coverage is 0.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #452     +/-   ##
========================================
- Coverage    63.3%   63.3%   -0.1%     
========================================
  Files         279     279             
  Lines       22787   22796      +9     
========================================
  Hits        14434   14434             
- Misses       8353    8362      +9     
Flag Coverage Δ
#gcc 63.3% <0.0%> (-0.1%) ⬇️
Impacted Files Coverage Δ
src/libxtp/calculators/kmclifetime.cc 0.0% <0.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d240a77...79fc1a4. Read the comment docs.

@JoshuaSBrown JoshuaSBrown merged commit 46df827 into master May 23, 2020
@JoshuaSBrown JoshuaSBrown deleted the JoshuaSBrown/fix-missing-includes branch May 23, 2020 00:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants