Skip to content
This repository has been archived by the owner on Sep 28, 2021. It is now read-only.

CI: turn coverage into own action #502

Merged
merged 1 commit into from
Jul 7, 2020
Merged

CI: turn coverage into own action #502

merged 1 commit into from
Jul 7, 2020

Conversation

junghans
Copy link
Member

@junghans junghans commented Jul 7, 2020

@junghans junghans requested a review from JensWehner July 7, 2020 15:12
@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #502 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #502   +/-   ##
======================================
  Coverage    52.7%   52.7%           
======================================
  Files         291     291           
  Lines       30330   30330           
======================================
  Hits        16012   16012           
  Misses      14318   14318           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d13d72f...149ee83. Read the comment docs.

@junghans junghans merged commit 1a61005 into master Jul 7, 2020
@junghans junghans deleted the ci_coverage branch July 7, 2020 17:12
votca-bot added a commit to votca/votca that referenced this pull request Jul 7, 2020
@junghans
Copy link
Member Author

junghans commented Jul 7, 2020

Hmm, the problem with two workflows is that the coverage workflow will still keep running, if the CI workflow already failed.

@junghans
Copy link
Member Author

junghans commented Jul 7, 2020

But writing them into one yaml as two jobs won't automatically cancel them either. We could make one job depend on the other using depend: just that would artificially serialize the execution.

So let's leave it like that for now until we find a better solution.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants