Skip to content
This repository has been archived by the owner on Sep 28, 2021. It is now read-only.

fix case no statefile exists yet and improved warnings #526

Merged
merged 4 commits into from
Aug 3, 2020

Conversation

JensWehner
Copy link
Member

I changed the locking behaviour earlier to make them more robust, but I forgot the case if no state file exists yet.

@JensWehner JensWehner requested a review from felipeZ August 3, 2020 12:56
@JensWehner
Copy link
Member Author

@votca-bot changelog: write an empty state file if it does not exist yet

Copy link
Member

@felipeZ felipeZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #526 into master will decrease coverage by 0.0%.
The diff coverage is 0.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #526     +/-   ##
========================================
- Coverage    52.3%   52.3%   -0.1%     
========================================
  Files         291     291             
  Lines       30587   30591      +4     
========================================
  Hits        16017   16017             
- Misses      14570   14574      +4     
Impacted Files Coverage Δ
src/libxtp/statesaver.cc 0.0% <0.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7417b3...f7f18f2. Read the comment docs.

@junghans junghans merged commit 999ca47 into master Aug 3, 2020
@junghans junghans deleted the stateserv_fix branch August 3, 2020 16:27
votca-bot added a commit to votca/votca that referenced this pull request Aug 3, 2020
@junghans junghans mentioned this pull request Aug 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants