Skip to content
This repository has been archived by the owner on Sep 28, 2021. It is now read-only.

moved cuda openmp into own subsystem #571

Merged
merged 10 commits into from
Oct 12, 2020
Merged

moved cuda openmp into own subsystem #571

merged 10 commits into from
Oct 12, 2020

Conversation

JensWehner
Copy link
Member

@JensWehner JensWehner commented Oct 11, 2020

The Cuda Openmp things are moved into a separate class, so that threecenter_gwbse only focuses on the physics and not on the scheduling.

@JensWehner
Copy link
Member Author

@votca-bot changelog: Refactored CUDA-OpenMP integration

@codecov
Copy link

codecov bot commented Oct 11, 2020

Codecov Report

Merging #571 into master will increase coverage by 0.0%.
The diff coverage is 96.6%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #571   +/-   ##
======================================
  Coverage    57.3%   57.3%           
======================================
  Files         312     313    +1     
  Lines       32391   32394    +3     
======================================
+ Hits        18565   18568    +3     
  Misses      13826   13826           
Impacted Files Coverage Δ
include/votca/xtp/threecenter.h 80.0% <ø> (ø)
src/libxtp/gwbse/gwbse.cc 0.0% <0.0%> (ø)
src/libxtp/bsecoupling.cc 64.3% <100.0%> (ø)
src/libxtp/openmp_cuda.cc 100.0% <100.0%> (ø)
src/libxtp/threecenter_gwbse.cc 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e3115b...00813b9. Read the comment docs.

Copy link
Member

@felipeZ felipeZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so much cleaner and easier to understand. Great Job @JensWehner!

@JensWehner JensWehner merged commit f932ae9 into master Oct 12, 2020
@JensWehner JensWehner deleted the cuda_refactor branch October 12, 2020 12:35
votca-bot added a commit to votca/votca that referenced this pull request Oct 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants