This repository has been archived by the owner on Sep 28, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@votca-bot changelog: Refactored CUDA-OpenMP integration |
Codecov Report
@@ Coverage Diff @@
## master #571 +/- ##
======================================
Coverage 57.3% 57.3%
======================================
Files 312 313 +1
Lines 32391 32394 +3
======================================
+ Hits 18565 18568 +3
Misses 13826 13826
Continue to review full report at Codecov.
|
felipeZ
approved these changes
Oct 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so much cleaner and easier to understand. Great Job @JensWehner!
rubengerritsen
approved these changes
Oct 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Cuda Openmp things are moved into a separate class, so that threecenter_gwbse only focuses on the physics and not on the scheduling.