Skip to content
This repository has been archived by the owner on Sep 28, 2021. It is now read-only.

perform check in orca unit test #594

Merged
merged 2 commits into from
Nov 12, 2020
Merged

perform check in orca unit test #594

merged 2 commits into from
Nov 12, 2020

Conversation

rubengerritsen
Copy link
Collaborator

Unit test was there, but no check was done for the polar part

@rubengerritsen rubengerritsen changed the title perform check perform check in orca unit test Nov 12, 2020
@rubengerritsen
Copy link
Collaborator Author

@votca-bot changelog: extra check in orca unit test

Copy link
Member

@JensWehner JensWehner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@rubengerritsen
Copy link
Collaborator Author

That was quick

@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #594 (100fc18) into master (382563f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #594   +/-   ##
======================================
  Coverage    51.5%   51.5%           
======================================
  Files         302     302           
  Lines       28815   28815           
======================================
  Hits        14846   14846           
  Misses      13969   13969           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 382563f...100fc18. Read the comment docs.

@rubengerritsen rubengerritsen merged commit 74269c0 into master Nov 12, 2020
@rubengerritsen rubengerritsen deleted the fixOrcaTest branch November 12, 2020 18:39
votca-bot added a commit to votca/votca that referenced this pull request Nov 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants