AGORA-1366/Port the HoverCard when hovering over a delegate on a vote table view #51
Conversation
…card-when-hovering-over-a-delegate-on-a-vote
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Apply Sweep Rules to your PR?
This is an automated message generated by Sweep AI. |
Yes plz customize to look like current. Esp important that it hangs to the side so it doenst obscure other votes. thanks! |
|
@yitongzhang i moved it to the left 🤝 |
…card-when-hovering-over-a-delegate-on-a-vote
|
Looks like Vercel's TS linter is more aggressive. |
| fetchDelegateAndSet(address); | ||
| }, []); | ||
|
|
||
| return ( |
There was a problem hiding this comment.
Love the look and feel. I would say comment out the supply calculation if that's what is taking too long, if it's the delegate statement, keep it! Love the look and feel.
There was a problem hiding this comment.
Updated version: Now the delegate statement is loaded before the rest of the delegate information
You can see that the voting power and the delegate button still display with a delay, but its more snappy now than before
https://www.loom.com/share/1ca36c1a70f44120905ddc4e9394f9fa?sid=293f96f8-70f9-44b9-9037-95452ed3255d
mcgingras
deleted the
wojciechkulikowski/agora-1366-port-the-hovercard-when-hovering-over-a-delegate-on-a-vote
branch
… table view (#51) * MVP of the hover card * Remove unused code * Add imports * Use Link next compontent * Rename VoterCard to VoterHoverCard * Remove the changes to delegate list * Fix fetchBalanceForDirectDelegation import * Move the hover to the left * Add the skeleton * Add missing fetching function * Load the statement before the full delegate object
… table view (#51) * MVP of the hover card * Remove unused code * Add imports * Use Link next compontent * Rename VoterCard to VoterHoverCard * Remove the changes to delegate list * Fix fetchBalanceForDirectDelegation import * Move the hover to the left * Add the skeleton * Add missing fetching function * Load the statement before the full delegate object
… table view (#51) * MVP of the hover card * Remove unused code * Add imports * Use Link next compontent * Rename VoterCard to VoterHoverCard * Remove the changes to delegate list * Fix fetchBalanceForDirectDelegation import * Move the hover to the left * Add the skeleton * Add missing fetching function * Load the statement before the full delegate object
… table view (#51) * MVP of the hover card * Remove unused code * Add imports * Use Link next compontent * Rename VoterCard to VoterHoverCard * Remove the changes to delegate list * Fix fetchBalanceForDirectDelegation import * Move the hover to the left * Add the skeleton * Add missing fetching function * Load the statement before the full delegate object
This PR adds a HoverCard in the vote table view
Updated video (V3): https://www.loom.com/share/1ca36c1a70f44120905ddc4e9394f9fa
✅ Functionality matches preview version, includes the voting power, delegate button, and social media buttons
❓ It loads very slowly on my computer.
fetchDelegateandfetchBalanceForDirectDelegationare taking a lot of time to display the delegate information and then to display the delegate button. Should i optimize it?