Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added error handling (unauthorized) from okta #46

Merged
merged 1 commit into from
Jan 16, 2019

Conversation

micromoses
Copy link
Contributor

This must be done before trying to get the user,
otherwise the app yields an 400 error:

oauth2: cannot fetch token: 400 Bad Request
Response: {"error":"invalid_grant","error_description":"The authorization code is invalid or has expired."}

This must be done before trying to get the user,
otherwise the app yields an 400 error:
```
oauth2: cannot fetch token: 400 Bad Request
Response: {"error":"invalid_grant","error_description":"The authorization code is invalid or has expired."}
```
@micromoses
Copy link
Contributor Author

Hi @bnfinet ,
It's been over a week, have you had a chance to take a look at this change?
Thanks!

@bnfinet
Copy link
Member

bnfinet commented Jan 13, 2019

I apologize but I have not and I won't be in a position to look at this until middle of next week.

I'm hoping to consult with @aaronpk about the Okta behavior that you are seeing. There is no current vendor specific testing in place.

@bnfinet
Copy link
Member

bnfinet commented Jan 16, 2019

Thanks for the contribution @micromoses

Just to make note here, there are also error_uri parameters and often the error parameter itself may be instructive. These parameters are not Okta specific and are part of the RFCs
https://tools.ietf.org/html/rfc6749

I'll open a ticket related to those items and general error handling.

@bnfinet bnfinet merged commit b65b7a1 into vouch:master Jan 16, 2019
bnfinet added a commit that referenced this pull request May 22, 2020
Added error handling (unauthorized) from okta
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants