-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancements to annotation rendering via ETA #408
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerganter
reviewed
Jan 18, 2020
tylerganter
reviewed
Jan 18, 2020
tylerganter
approved these changes
Jan 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added an additional flag show_object_attrs
to toggle object attributes. Some minor comments but otherwise looks great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following new parameters have been added to
eta.core.annotations.AnnotationConfig
(and thereby usable when running thevisualize_labels
module orvisualize_labels
pipeline):The only non-backwards compatible change is that all object attributes will now be rendered as a
panel
.Object attribute rendering
object_attrs_render_method = ["list", "panel"]
: the method used to render object attributes. Previous behavior waslist
. New option ispanel
, which renders object attributes in a panel in the same way that frame attributes are rendered. I find this far easier to grok, so I madepanel
the new defaultHandling of occluded objects
occluded_object_attr
: the name of the boolean attribute indicating whether an object is occluded. Typically this isoccluded
hide_occluded_objects = True/False
: whether to hide objects when theiroccluded_object_attr
takes the valueFalse
Handling of boolean attributes
hide_false_boolean_attrs = True/False
: whether to hide boolean attributes when they areFalse
, rather than rendering<attr>: False
Hiding of specific attribute values
hide_attr_values = <list>
: an optional list of video/frame/object attribute values to NOT RENDER if they appear in the labels. A typical use of this is to hide attributes whose value isunclear
Example of how object attributes now look in panel-mode (the new default):
Same labels as above, but hiding
unclear
attributes: