Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements to annotation rendering via ETA #408

Merged
merged 12 commits into from
Jan 18, 2020
Merged

Enhancements to annotation rendering via ETA #408

merged 12 commits into from
Jan 18, 2020

Conversation

brimoor
Copy link
Contributor

@brimoor brimoor commented Jan 17, 2020

The following new parameters have been added to eta.core.annotations.AnnotationConfig (and thereby usable when running the visualize_labels module or visualize_labels pipeline):

The only non-backwards compatible change is that all object attributes will now be rendered as a panel.

Object attribute rendering

  • object_attrs_render_method = ["list", "panel"]: the method used to render object attributes. Previous behavior was list. New option is panel, which renders object attributes in a panel in the same way that frame attributes are rendered. I find this far easier to grok, so I made panel the new default

Handling of occluded objects

  • occluded_object_attr: the name of the boolean attribute indicating whether an object is occluded. Typically this is occluded
  • hide_occluded_objects = True/False: whether to hide objects when their occluded_object_attr takes the value False

Handling of boolean attributes

  • hide_false_boolean_attrs = True/False: whether to hide boolean attributes when they are False, rather than rendering <attr>: False

Hiding of specific attribute values

  • hide_attr_values = <list>: an optional list of video/frame/object attribute values to NOT RENDER if they appear in the labels. A typical use of this is to hide attributes whose value is unclear

Example of how object attributes now look in panel-mode (the new default):
Screen Shot 2020-01-17 at 1 36 21 PM

Same labels as above, but hiding unclear attributes:
Screen Shot 2020-01-17 at 1 37 02 PM

@brimoor brimoor added the feature Work on a feature request label Jan 17, 2020
@brimoor brimoor requested a review from a team January 17, 2020 18:46
@brimoor brimoor self-assigned this Jan 17, 2020
Copy link
Contributor

@tylerganter tylerganter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added an additional flag show_object_attrs to toggle object attributes. Some minor comments but otherwise looks great!

@brimoor brimoor merged commit dd60193 into develop Jan 18, 2020
@brimoor brimoor deleted the anno-render branch January 18, 2020 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Work on a feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants