Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm large Google Drive downloads #554

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Confirm large Google Drive downloads #554

merged 1 commit into from
Feb 17, 2022

Conversation

ehofesmann
Copy link
Member

The previous method for confirming large file downloads from Google Drive seems to no longer work, this PR resolves that.

Example

import eta.core.web as etaw

fid_large = "1O-WMjtiBBMXGEHnnus6y2nSlJu8pY5vo"
fid_small = "1UWTlFmdq8H-wdJHxVsAKpXBilY1CWwm_"

_ = etaw.download_google_drive_file(fid_large)
# Previous download size: 17.3Kb
# Now: 281.7Mb

_ = etaw.download_google_drive_file(fid_small)
# Previous download size: 188.0Mb
# Now: 188.0Mb

Adding "confirm": "t" to the params also works for smaller files that do not raise a prompt, however, I was unable to find much information about this. There may be some cases in which the old method of confirming the prompt through cookies is still required so I didn't remove that.

@ehofesmann ehofesmann added the bug Bug fixes label Feb 17, 2022
@ehofesmann ehofesmann requested a review from a team February 17, 2022 16:13
@ehofesmann ehofesmann self-assigned this Feb 17, 2022
Copy link
Contributor

@brimoor brimoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants