Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for models with no managers and requirements.txt files on disk #596

Merged
merged 4 commits into from
Aug 1, 2023
Merged

Adding support for models with no managers and requirements.txt files on disk #596

merged 4 commits into from
Aug 1, 2023

Conversation

brimoor
Copy link
Contributor

@brimoor brimoor commented May 3, 2023 •
edited
Loading

Changelog

  • makes the manager property of eta.core.models.Model instances optional.
  • adds support for loading package requirements for models from a requirements.txt file on disk

@brimoor brimoor added the enhancement Code enhancement label May 3, 2023
@brimoor brimoor requested a review from a team May 3, 2023 01:56
@brimoor brimoor self-assigned this May 3, 2023
@brimoor brimoor mentioned this pull request May 3, 2023
Merged
@brimoor brimoor changed the title Adding support for models with no managers Adding support for models with no managers and requirements.txt files on disk May 3, 2023
@brimoor brimoor changed the title Adding support for models with no managers and requirements.txt files on disk [HOLD] Adding support for models with no managers and requirements.txt files on disk May 17, 2023
@brimoor brimoor changed the title [HOLD] Adding support for models with no managers and requirements.txt files on disk Adding support for models with no managers and requirements.txt files on disk Aug 1, 2023
@brimoor brimoor changed the base branch from develop to release/v0.11.0 August 1, 2023 15:05
@brimoor brimoor mentioned this pull request Aug 1, 2023
Merged
@brimoor
Copy link
Contributor Author

brimoor commented Aug 1, 2023

I've been using this locally for months and it is all pre-FiftyOne code, so I'm just going to merge

@brimoor brimoor merged commit 0adb8a4 into release/v0.11.0 Aug 1, 2023
@brimoor brimoor deleted the no-model-manager branch August 1, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brimoor brimoor

Labels
enhancement Code enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brimoor