Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing cv2 colab fix #2058

Merged
merged 4 commits into from
Sep 8, 2022
Merged

Removing cv2 colab fix #2058

merged 4 commits into from
Sep 8, 2022

Conversation

brimoor
Copy link
Contributor

@brimoor brimoor commented Sep 2, 2022

Removes the warning below, since I'm no longer seeing this issue in Colab 🥳 🎈

If the above import fails due to a cv2 error, it is an issue with OpenCV in Colab environments. Follow these instructions to resolve it.

Adds a suggestion to install fiftyone==0.15.1 when working in Google Colab, since the App is currently buggy in Colab with fiftyone>=0.16,<0.17 <-- no longer needed, thank you #2069!

@brimoor brimoor added the bug Bug fixes label Sep 2, 2022
@brimoor brimoor requested review from ehofesmann and a team September 2, 2022 21:46
@brimoor brimoor self-assigned this Sep 2, 2022
Copy link
Member

@ehofesmann ehofesmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need to add the v0.15.1 suggestion if we can get this fixed in v0.17, which would be the next release anyway?

@brimoor
Copy link
Contributor Author

brimoor commented Sep 2, 2022

Do we really need to add the v0.15.1 suggestion if we can get this fixed in v0.17, which would be the next release anyway?

Yeah good point, how about we leave this PR in an open state so that we can remove it if the colab fixes make it into v0.17.

Note that it would be valuable to merge voxel51/fiftyone-examples#41 ASAP because fiftyone.ai pulls directly from the master branch over there, so users will immediately benefit pre v0.17 release.

@brimoor brimoor changed the title Adding 0.15.1 suggestion for colab Removing cv2 colab fix Sep 8, 2022
Copy link
Member

@ehofesmann ehofesmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Ready to merge after #2069

ehofesmann and others added 2 commits September 8, 2022 12:03
Update evaluate detections notebook to use `only_matches=False` when filtering labels
@brimoor brimoor merged commit 9427f57 into develop Sep 8, 2022
@brimoor brimoor deleted the bugfix/colab branch September 8, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants