Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CVAT v2.4 #2597

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Add support for CVAT v2.4 #2597

merged 1 commit into from
Feb 2, 2023

Conversation

ehofesmann
Copy link
Member

@ehofesmann ehofesmann commented Feb 2, 2023

Resolves #2572
Resolves #2567
Resolves #2565

Thanks to @tjaeuth for the recommendation!

The CVAT API response for the jobs query has been modified slightly which broke our integration for v2.4 servers. This PR adds support for v2.4 servers and updates our tests. All tests pass on both v2.3 and v2.4 now.

@ehofesmann ehofesmann added bug Bug fixes annotation Issues related to FiftyOne's annotation API labels Feb 2, 2023
@ehofesmann ehofesmann requested a review from a team February 2, 2023 00:31
@ehofesmann ehofesmann self-assigned this Feb 2, 2023
@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Base: 62.58% // Head: 62.56% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (712bd70) compared to base (07ad394).
Patch coverage: 20.83% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2597      +/-   ##
===========================================
- Coverage    62.58%   62.56%   -0.02%     
===========================================
  Files          249      249              
  Lines        42113    42142      +29     
  Branches       346      347       +1     
===========================================
+ Hits         26356    26366      +10     
- Misses       15757    15776      +19     
Flag Coverage Δ
app 50.16% <20.83%> (-0.02%) ⬇️
python 99.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/packages/state/src/hooks/useStateUpdate.ts 27.97% <0.00%> (ø)
app/packages/state/src/routing/RouteDefinition.ts 71.42% <0.00%> (-1.16%) ⬇️
app/packages/state/src/routing/RouterContext.ts 42.75% <0.00%> (-0.15%) ⬇️
app/packages/state/src/routing/matchPath.ts 40.00% <0.00%> (ø)
app/packages/state/src/utils.ts 21.12% <0.00%> (ø)
app/packages/state/src/hooks/useSetView.ts 20.16% <11.76%> (+1.76%) ⬆️
...pp/packages/state/src/recoil/pathFilters/string.ts 47.02% <26.66%> (-3.95%) ⬇️
app/packages/state/src/recoil/pathFilters/index.ts 35.33% <33.33%> (-0.60%) ⬇️
app/packages/state/src/hooks/useSessionSpaces.ts 34.02% <50.00%> (+0.68%) ⬆️
app/packages/looker/src/index.ts 100.00% <100.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@swheaton swheaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
annotation Issues related to FiftyOne's annotation API bug Bug fixes
Projects
None yet
3 participants