(PUP-9212) Allow for building containers with context #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, beaker-docker would copy the file contents of a supplied dockerfile and use that to generate a new image. This had the drawback of not being able to use much of the Dockerfile DSL, such as COPY or VOLUME, because they were relative paths that were not copied along with the Dockerfile itself. This commit changes it so that a dockerfile is copied along with the context of the test execution directory, so that those Dockerfile DSL methods are usable with a Dockerfile used by beaker.
tvpartytonight
force-pushed
the
PUP-9212
branch
from
68820b7
to
027380b
Compare
|
@kevpl this some improved testing and host examples, as requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, beaker-docker would copy the file contents of a
supplied dockerfile and use that to generate a new image. This had the
drawback of not being able to use much of the Dockerfile DSL, such as
COPY or VOLUME, because they were relative paths that were not copied
along with the Dockerfile itself.
This commit changes it so that a dockerfile is copied along with the
context of the test execution directory, so that those Dockerfile DSL
methods are usable with a Dockerfile used by beaker.